[SYCL][NFC] Re-enable sycl.c test on Windows #15433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enabling for testing purposes. Am unable to reproduce locally.
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hchilama
approved these changes
Sep 20, 2024
|
@intel/llvm-gatekeepers , this looks ready for merge, please take a look thanks! |
KornevNikita
pushed a commit
that referenced
this pull request
Dec 5, 2024
The issue dealt with the resetting of the PATH environment variable. This was masking potential runtime dependencies (DLLs and such) for other tools being used when running the test. The solution is to append the PATH for the dummy `aoc` instead of overwriting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue dealt with the resetting of the PATH environment variable. This was masking potential runtime dependencies (DLLs and such) for other tools being used when running the test. The solution is to append the PATH for the dummy
aocinstead of overwriting.