[SYCL] Tests cleanup for warnings issued due to attributes applied to non-kernel functions #15440
Conversation
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| #endif | ||
|
|
||
| // Produce a conflicting attribute warning when the args are different. | ||
| [[sycl::work_group_size_hint(4, 1, 1)]] void f3(); // expected-note {{previous attribute is here}} |
There was a problem hiding this comment.
This can be removed. We already test this in Functor1
There was a problem hiding this comment.
Ideally all these tests on device functions should be rewritten on kernel I think since the usage on device function is not correct. I understand that is a lot of work for something of lower priority though. If you can work on that we would appreciate it, but if you cannot, please add a FIXME to all these tests explaining these attributes are incorrectly applied to device functions and the tests should be eventually rewritten.
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days. |
|
This pull request was closed because it has been stalled for 30 days with no activity. |
2 participants
Tests cleanup as follow up PR to already merged #15154