[SYCL][E2E] Add missing %{run-unfiltered-devices} to e2e tests
#15636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
approved these changes
Oct 8, 2024
Contributor
sarnex
left a comment
sarnex
left a comment
There was a problem hiding this comment.
lgtm, but i have a similar comment about needing some automation to enforce this for new tests in the future
againull
approved these changes
Oct 8, 2024
ayylol
changed the title
%{run-unfiltered-devices} to e2e tests
EwanC
approved these changes
Oct 9, 2024
aarongreig
approved these changes
Oct 9, 2024
Seanst98
approved these changes
Oct 9, 2024
cppchedy
approved these changes
Oct 9, 2024
cperkinsintel
approved these changes
Oct 9, 2024
This was referenced Oct 30, 2024
againull
pushed a commit
that referenced
this pull request
Oct 31, 2024
Added `%{run}` to lit lines that execute the test binary.
Same change as #15636 to some tests that were added recently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of tests execute without using either the
%{run}or%{run-unfiltered-devices}expansion. This patch adds%{run-unfiltered-devices}to these test (and%{run}to one test).