[SYCL][COMPAT] Re-add buffer (USM_LEVEL_NONE) support #15683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commiting before modifying to fit syclcompat
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
I've merged |
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alcpz
suggested changes
Oct 21, 2024
sycl/test-e2e/syclcompat/memory/memory_is_device_ptr_usmnone.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Alberto Cabrera Pérez <[email protected]>
joeatodd
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
joeatodd
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
joeatodd
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Not allowed to nest q.submit for the memcpy when using buffer support.
For buffer support
Not sure why this was needed.
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
LGTM, great work @joeatodd |
Alcpz
approved these changes
Oct 23, 2024
|
@intel/llvm-gatekeepers this is ready to merge 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables (a subset of) the SYCLcompat memory APIs on devices which lack USM support.
Defining
COMPAT_USM_LEVEL_NONEenables this mode, in whichsyclcompatmemory APIs (malloc,memcpy,memset,free, etc) operate with virtual device pointers, backed by buffers.