-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL][COMPAT] Re-add buffer (USM_LEVEL_NONE) support #15683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 44 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
5656b91
Add mem_mgr class & buffer_t def
joeatodd d7898cb
Bring DPCT_USM_LEVEL_NONE code from dpct
joeatodd 8dc0252
s/DPCT_USM/COMPAT_USM/
joeatodd c569ffe
Formatting & naming
joeatodd 3d6562d
First effort at docs
joeatodd 6b59b8b
Adding SYCLomatic-test tests as-is
joeatodd a735aef
compatify
joeatodd c65a025
Add build & run cmds
joeatodd 26f63e0
renaming files
joeatodd 4f70acb
compatify
joeatodd c7dcf91
compatify otra vez
joeatodd d22c4eb
compatify ultima vez
joeatodd 3890f2d
Remove autocomments
joeatodd 4a0ecd6
Add memory_common header to tests
joeatodd 03a843b
s/dpct_kernel_name/syclcompat_kernel_name/
joeatodd 7ebca22
Replace deprecated get_pointer()
joeatodd 8d4e426
Remove mempcy_direction in the hopes its unnecessary
joeatodd fe6a0f6
memory_region is a class enum now
joeatodd 03e0ff2
__PRETTY_FUNCTION__
joeatodd 8388754
Test constant_memory object at global scope
joeatodd 9f38b41
Can't write to a constant_memory region!
joeatodd 3b497f7
Delete redundant tests
joeatodd a0a2817
Name tests properly
joeatodd 26801fc
Fix comment typo
joeatodd 72455f3
Remove redundant macro
joeatodd 31b672b
pointer_t for constant_memory should be `const T *`
joeatodd 80698ea
Update the README
joeatodd 397c04e
Deprecate syclcompat::target in favour of sycl::target
joeatodd fa610e4
get_pointer -> get_multi_ptr
joeatodd a8ca6d1
Add USM_LEVEL_NONE specific fns
joeatodd de6de4e
Ensure lifetime of mem_mgr w.r.t. global-scope memory objects
joeatodd 10cacd7
Harmonise new code w/ existing
joeatodd 4ed2073
Delete old TODOs
joeatodd e3986cc
Updates to fill & memset
joeatodd 580c4f7
Move memcpy_direction to detail
joeatodd cea476c
Formatting
joeatodd c7e44ad
Implement `syclcompat::free` using `detail::free`
joeatodd 4720439
Re-enable memory_async tests since race condition is fixed
joeatodd 2507bd8
Generalize AsyncTest to work with buffers too
joeatodd 05a7f14
Implement enqueue_free using detail:free (handle buffers)
joeatodd 3d7997f
Consolidate TODO for multi-device device_memory
joeatodd 5b8dc3c
Replace sycl.hpp with sycl/detail/core.hpp
joeatodd 2bddb98
Fix markdown reference
joeatodd 9951ec0
Merge branch 'sycl' into jtodd/usm_level_none
joeatodd d3f8312
Apply suggestions from code review
joeatodd 1d02f69
s/COMPAT_USM_LEVEL_NONE/SYCLCOMPAT_USM_LEVEL_NONE/
joeatodd 2b72e40
As prev, in memory.hpp
joeatodd 1781d5f
Address review feedback
joeatodd d984042
Improve variable naming
joeatodd 2cc74ed
Actually check values in shared_memory_usmnon.cpp
joeatodd e435853
Improve test
joeatodd 1042c8e
Move global/constant memory init() outside of cgh lambda
joeatodd 7b88d79
Implement wait_and_free using detail::free
joeatodd 834d941
Remove wait() in syclcompat::free for USM case
joeatodd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.