[UR] Handle INVALID_VALUE in OCL urPlatformGet #15779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Pre-commit MR for: oneapi-src/unified-runtime#2227 As there is a spec change in UR, adapter handling code has been updated - it no longer tries to populate the platform list if it would be empty (otherwise both "destination" pointers could be null, which is now illegal). This fixes a bug Intel tracks internally as URT-831
RossBrunton
force-pushed
the
ross/platformget
branch
from
0611561 to
817b3eb
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-reviewers-runtime please take a look when you can |
aarongreig
approved these changes
Oct 29, 2024
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-reviewers-runtime please review, it's a trivial change which is blocking our merge queue now |
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-commit MR for: oneapi-src/unified-runtime#2227
As there is a spec change in UR, adapter handling code has been updated -
it no longer tries to populate the platform list if it would be empty
(otherwise both "destination" pointers could be null, which is now
illegal).
This fixes a bug Intel tracks internally as URT-831