Skip to content

[UR] Handle INVALID_VALUE in OCL urPlatformGet #15779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2024
Merged

[UR] Handle INVALID_VALUE in OCL urPlatformGet #15779

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
817b3eb
[UR] Handle INVALID_VALUE in OCL urPlatformGet
RossBrunton Oct 21, 2024
20e7d1e
Merge branch 'sycl' into ross/platformget
aarongreig Oct 29, 2024
6dbeb11
Merge branch 'sycl' into ross/platformget
aarongreig Oct 31, 2024
ddda6c2
Merge branch 'sycl' into ross/platformget
aarongreig Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sycl/cmake/modules/UnifiedRuntimeTag.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# commit a9c7aef861988d4b8421f3e760e63f4e3da9398d (HEAD, origin/main, origin/HEAD)
# Merge: dbd168c 3142142
# commit 884b646ca3b4c17c4efc56937d34ddcdc81de9a9
# Merge: f31bec36 9989d97b
# Author: aarongreig <[email protected]>
# Date: Mon Oct 28 15:56:46 2024 +0000
# Merge pull request #2152 from Bensuo/fabio/binary_update_fix
# Fix command-buffer binary update implementation
set(UNIFIED_RUNTIME_TAG a9c7aef861988d4b8421f3e760e63f4e3da9398d)
# Date: Tue Oct 29 10:38:34 2024 +0000
# Merge pull request #2227 from RossBrunton/ross/platformget
# Handle INVALID_VALUE in OCL urPlatformGet
set(UNIFIED_RUNTIME_TAG 884b646ca3b4c17c4efc56937d34ddcdc81de9a9)
6 changes: 4 additions & 2 deletions sycl/source/detail/adapter.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,10 @@ class Adapter {
uint32_t platformCount = 0;
call<UrApiKind::urPlatformGet>(&MAdapter, 1, 0, nullptr, &platformCount);
UrPlatforms.resize(platformCount);
call<UrApiKind::urPlatformGet>(&MAdapter, 1, platformCount,
UrPlatforms.data(), nullptr);
if (platformCount) {
call<UrApiKind::urPlatformGet>(&MAdapter, 1, platformCount,
UrPlatforms.data(), nullptr);
}
// We need one entry in this per platform
LastDeviceIds.resize(platformCount);
});
Expand Down
Loading