Skip to content

Disable zstd even under --ci-defaults in sycl-web #15840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Disable zstd even under --ci-defaults in sycl-web #15840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion buildbot/configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ def do_configure(args):
# For clang-format, clang-tidy and code coverage
llvm_enable_projects += ";clang-tools-extra;compiler-rt"
# Build with zstd enabled on CI.
llvm_enable_zstd = "ON"
# Disable in sycl-web , we don't have zstd in pulldown env.
Copy link
Contributor

@bader bader Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sycl-web is merged to sycl, so we better have the same behavior in both branches.

Copy link
Contributor Author

@jsji jsji Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to unblock the pulldown first , I expect that @uditagarwal97 will have a better fix to make sure enabling zstd on a machine without zstd build as well.

Even if we can't get the good fix in time before next pulldown to sycl branch, we can resolve the conflicts to keep it on for sycl branch.

Copy link
Contributor

@uditagarwal97 uditagarwal97 Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsji To have the same behavior in sycl and sycl-web, we can disable zstd even in sycl branch for now. I'm investigating the build issue and will re-enable zstd after fixing.

Copy link
Contributor

@bader bader Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsji To have the same behavior in sycl and sycl-web, we can disable zstd even in sycl branch for now. I'm investigating the build issue and will re-enable zstd after fixing.

This plan sounds good me.

llvm_enable_zstd = "OFF" # INTEL
if sys.platform != "darwin":
# libclc is required for CI validation
libclc_enabled = True
Expand Down