Disable zstd even under --ci-defaults in sycl-web #15840
Conversation
|
Just curious, why do we use |
| llvm_enable_projects += ";clang-tools-extra;compiler-rt" | ||
| # Build with zstd enabled on CI. | ||
| llvm_enable_zstd = "ON" | ||
| # Disable in sycl-web , we don't have zstd in pulldown env. |
There was a problem hiding this comment.
sycl-web is merged to sycl, so we better have the same behavior in both branches.
There was a problem hiding this comment.
this is to unblock the pulldown first , I expect that @uditagarwal97 will have a better fix to make sure enabling zstd on a machine without zstd build as well.
Even if we can't get the good fix in time before next pulldown to sycl branch, we can resolve the conflicts to keep it on for sycl branch.
There was a problem hiding this comment.
@jsji To have the same behavior in sycl and sycl-web, we can disable zstd even in sycl branch for now. I'm investigating the build issue and will re-enable zstd after fixing.
There was a problem hiding this comment.
@jsji To have the same behavior in sycl and sycl-web, we can disable zstd even in sycl branch for now. I'm investigating the build issue and will re-enable zstd after fixing.
This plan sounds good me.
sycl-web is "future" sycl i.e. sycl + latest patches from llvm.org. To make sure that we catch the problems, we should configure it the same way as we do for sycl branch. |
We want to test as much as possible in sycl-web pulldown, or else we will get some last minutes surprise when doing pulldown to sycl branch. |
|
#15842 to disable in sycl. |
We don't have zstd in sycl-web pulldown build env.