Skip to content

Conversation

uditagarwal97
Copy link
Contributor

zstd got disable in CI by a bad merge in 9e1505c
This PR re-enables zstd in CI.

@uditagarwal97 uditagarwal97 self-assigned this Oct 16, 2025
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner October 16, 2025 17:50
python3 $GITHUB_WORKSPACE/src/buildbot/configure.py -w $GITHUB_WORKSPACE \
-s $GITHUB_WORKSPACE/src -o $GITHUB_WORKSPACE/build -t Release \
--ci-defaults --hip --cuda \
--ci-defaults --use-zstd --hip --cuda \
Copy link
Contributor

@KornevNikita KornevNikita Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to move this to --ci-defaults? or something like:

    if args.use_zstd or args.ci_defaults::
        llvm_enable_zstd = "FORCE_ON"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--ci-defaults is used in sycl-web and the runners used in sycl-web testing don't have zstd installed. I did try moving it to --ci-defaults in the past, but that ended up breaking pulldown testing. For reference: #15840

@sarnex
Copy link
Contributor

sarnex commented Oct 17, 2025

Test d:\github_work\llvm\llvm\build-e2e\reduction\output\reduction_ctor.cpp.tmp.out hung!

on Win BMG, unclear if actually related tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants