[SYCL][E2E] Use XFAIL: run-mode in xfailed tests that can compile
#15891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayylol
changed the title
XFAIL: run-mode to xfailed tests that can compileXFAIL: run-mode in xfailed tests that can compile
sarnex
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Though I think the changes look good, I think it is a little premature to make these changes before we have even decided on going ahead with #15728.
YuriPlyakhin
approved these changes
Oct 28, 2024
|
Gonna mark this as a draft until #15728 is further along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are able to compile but fail when running. Due to this they are marked as
XPASSwhen running split build mode from #15728. Marking these withXFAIL: run-modemeans these will pass normally when compiling and be marked asXFAILonly when running.