[UR] Stop using extension strings to report support for exp features. #16046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change all experimental features now add a ur_device_info_t enum which adapters report support through, and all EXTENSION_STRING macros have been removed.
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Also update DEVICE_INFO_EXTENSIONS description.
Contributor
Author
|
UR changes ported from oneapi-src/unified-runtime#2304 |
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
approved these changes
Feb 24, 2025
Contributor
frasercrmck
left a comment
frasercrmck
left a comment
There was a problem hiding this comment.
CUDA UR LGTM (already approved older PR)
hvdijk
approved these changes
Feb 24, 2025
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Bensuo
approved these changes
Feb 25, 2025
Contributor
Bensuo
left a comment
Bensuo
left a comment
There was a problem hiding this comment.
Commad-buffer changes LGTM!
ur_exp_command_buffer is also present in the UR mock adapter in the SYCL unit tests
llvm/sycl/unittests/helpers/UrMock.hpp
Line 159 in 6dc419f
I don't think it's used anywhere, could you remove that as well?
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
force-pushed
the
aaron/stopUsingURExtStrings
branch
from
ab30866 to
748cf38
Compare
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Feb 26, 2025
kbenzie
approved these changes
Mar 3, 2025
Contributor
kbenzie
left a comment
kbenzie
left a comment
There was a problem hiding this comment.
LGTM, source needs to be regenerated to resolve the conflicts
Contributor
Author
|
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change all experimental features now add a ur_device_info_t enum which adapters report support through, and all EXTENSION_STRING macros have been removed.