Skip to content

Report support for experimental features with device info queries. #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aarongreig wants to merge 2 commits into from
Closed

Report support for experimental features with device info queries. #2304

aarongreig wants to merge 2 commits into from

Conversation

@aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Nov 8, 2024

This will be the last bit of work I do to address #1374 for the time being, it aims to establish device info queries as the expected mechanism for adapters to report support for experimental features.

@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues native-cpu Native CPU adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Nov 8, 2024
@aarongreig aarongreig force-pushed the aaron/stopUsingURExtStrings branch 3 times, most recently from 56f53be to 372ce7c Compare November 11, 2024 16:36
@aarongreig
Copy link
Contributor Author

aarongreig commented Nov 11, 2024

LLVM PR intel/llvm#16046

@aarongreig aarongreig force-pushed the aaron/stopUsingURExtStrings branch from 372ce7c to e791acb Compare November 11, 2024 16:46
@aarongreig aarongreig marked this pull request as ready for review November 12, 2024 10:18
@aarongreig aarongreig requested review from a team as code owners November 12, 2024 10:18
@aarongreig aarongreig requested a review from ldrumm November 12, 2024 10:18
@EwanC EwanC mentioned this pull request Dec 13, 2024
Merged
@aarongreig aarongreig force-pushed the aaron/stopUsingURExtStrings branch from 3d19e78 to 9c1c7c7 Compare January 22, 2025 15:19
@github-actions github-actions bot added the opencl OpenCL adapter specific issues label Jan 22, 2025
@aarongreig aarongreig force-pushed the aaron/stopUsingURExtStrings branch from 9c1c7c7 to 75e4028 Compare February 4, 2025 15:50
@aarongreig aarongreig added the ready to merge Added to PR's which are ready to merge label Feb 6, 2025
@martygrant
Copy link
Contributor

martygrant commented Feb 20, 2025

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days.
To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.

This is an automated comment.

@aarongreig aarongreig closed this Feb 24, 2025
@aarongreig aarongreig mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbalcer pbalcer pbalcer approved these changes

@ldrumm ldrumm Awaiting requested review from ldrumm ldrumm was automatically assigned from oneapi-src/unified-runtime-hip-write

+4 more reviewers

@frasercrmck frasercrmck frasercrmck approved these changes

@kbenzie kbenzie kbenzie approved these changes

@EwanC EwanC EwanC approved these changes

@coldav coldav coldav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

command-buffer Command Buffer feature addition/changes/specification conformance Conformance test suite issues. cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aarongreig @martygrant @frasercrmck @kbenzie @EwanC @pbalcer @coldav