[NFCI][SYCL] Remove most uses of ContainsProperty
#16103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, `properties` itself has an interface that does exactly that. Second, this trait uses `std::tuple` which is relatively expensive to instantiate and that happens *on top* of the normal `properties` instantation that doesn't use `std::tuple` anymore. Remaining uses are related to `ConflictingProperties` which is ugly enough to be addressed in a separate PR.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
approved these changes
Nov 18, 2024
Contributor
maarquitos14
left a comment
maarquitos14
left a comment
There was a problem hiding this comment.
Just a question, otherwise looks good to me.
| ContainsProperty<read_write_mode_key, list>::value || | ||
| ContainsProperty<maxburst_key, list>::value || | ||
| ContainsProperty<wait_request_key, list>::value; | ||
| has_one_of<buffer_location_key, awidth_key, dwidth_key, latency_key, |
Contributor
There was a problem hiding this comment.
buffer_location_key was not present before. Do we need it now?
Contributor
Author
There was a problem hiding this comment.
No, copy-paste mistake. Thanks for noticing!
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First,
propertiesitself has an interface that does exactly that. Second, this trait usesstd::tuplewhich is relatively expensive to instantiate and that happens on top of the normalpropertiesinstantation that doesn't usestd::tupleanymore.Remaining uses are related to
ConflictingPropertieswhich is ugly enough to be addressed in a separate PR.