[CI] Fix igc-dev Docker container and bump version #16271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
sarnex
changed the title
sarnex
requested review from
YixingZhang007,
aelovikov-intel,
jsji and
uditagarwal97
|
LGTM, and thanks for helping resolve the issue! The tests joint_matrix_bf16_fill_k_cache_arg_dim.cpp and joint_matrix_bf16_fill_k_cache_runtime_dim.cpp pass on PVC but fail on the DG2 machine. I believe this is a bug in IGC rather than the CI, so XFAIL: gpu-intel-dg2 is added to these tests. |
YixingZhang007
approved these changes
Dec 16, 2024
| // Waiting for the commit in IGC to be pulled into the driver to resolve the | ||
| // test. | ||
| // XFAIL: gpu | ||
| // XFAIL: !igc-dev || gpu-intel-dg2 |
There was a problem hiding this comment.
@YixingZhang007 , XFAIL-TRACKER jira pointed below is submitted against PVC issue, that you fixed. If test is passing on PVC and is failing on DG2, it should be different jira, since problem is different. Could you please update xfail tracker?
There was a problem hiding this comment.
For sure! I will create a new Jira issue regarding this and update the tracker :)
YuriPlyakhin
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
igc-dev is using
libigc.so.2and released igc is usinglibigc.so.1, and there's no symlink tolibigc.soin the dev-igc packages, so we need to do it ourselves.Also, fix the workflow so it runs on changes to the driver install script and XFAIL failing tests.
And manually update the igc-dev version since the one we are using here is too old and the artifacts are expired so we can't build the image. The new version also contains an important fix for the joint matrix team.
Closes: #16088
Closes: #16251