Skip to content

[CI] Fix igc-dev Docker container and bump version #16271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[CI] Fix igc-dev Docker container and bump version #16271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/sycl-containers-igc-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ on:
- sycl
paths:
- 'devops/actions/build_container/**'
- 'devops/scripts/**'
- 'devops/dependencies-igc-dev.json'
- '.github/workflows/sycl-containers-igc-dev.yaml'
pull_request:
paths:
- 'devops/actions/build_container/**'
- 'devops/scripts/**'
- 'devops/dependencies-igc-dev.json'
- '.github/workflows/sycl-containers-igc-dev.yaml'

Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/sycl-linux-precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ jobs:
install_dev_igc_driver: >-
${{ !contains(matrix.target_devices, 'ext_oneapi_cuda') &&
!contains(matrix.target_devices, 'ext_oneapi_hip') &&
matrix.use_igc_dev && contains(needs.detect_changes.outputs.filters, 'devigccfg') ||
matrix.use_igc_dev &&
(contains(needs.detect_changes.outputs.filters, 'devigccfg') || contains(needs.detect_changes.outputs.filters, 'drivers')) ||
'false' }}
# Run only if the PR does not have the 'ci-no-devigc' label.
skip_run: ${{matrix.use_igc_dev && contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') || 'false'}}
Expand Down
8 changes: 4 additions & 4 deletions devops/dependencies-igc-dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"linux": {
"igc_dev": {
"github_tag": "igc-dev-3db59df",
"version": "3db59df",
"updated_at": "2024-12-03T20:43:00Z",
"url": "https://api.github.com/repos/intel/intel-graphics-compiler/actions/artifacts/2248119261/zip",
"github_tag": "igc-dev-e0d826a",
"version": "e0d826a",
"updated_at": "2024-12-17T21:18:30Z",
"url": "https://api.github.com/repos/intel/intel-graphics-compiler/actions/artifacts/2327583926/zip",
"root": "{DEPS_ROOT}/opencl/runtime/linux/oclgpu"
}
}
Expand Down
3 changes: 3 additions & 0 deletions devops/scripts/install_drivers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ InstallIGFX () {
echo "Install libopencl-clang"
# Workaround only, will download deb and install with dpkg once fixed.
cp -d libopencl-clang.so.14* /usr/local/lib/
rm /usr/local/lib/libigc.so /usr/local/lib/libigc.so.1* && \
ln -s /usr/local/lib/libigc.so.2 /usr/local/lib/libigc.so && \
ln -s /usr/local/lib/libigc.so.2 /usr/local/lib/libigc.so.1
echo "Clean up"
rm *.deb libopencl-clang.so.14*
echo "$IGC_DEV_TAG" > /usr/local/lib/igc/IGCTAG.txt
Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/ESIMD/PerformanceTests/invoke_simd_smoke.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// XFAIL: igc-dev
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388
// REQUIRES: gpu-intel-dg2 && level_zero
// UNSUPPORTED: windows

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/ESIMD/PerformanceTests/matrix_transpose.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// XFAIL: igc-dev
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16088
// REQUIRES: gpu-intel-dg2 && level_zero
// UNSUPPORTED: windows

Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/ESIMD/accessor_local.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
// REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677
// XFAIL: igc-dev
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
// This test verifies usage of local_accessor methods operator[]
Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
//
//===----------------------------------------------------------------------===//
// REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677
// XFAIL: igc-dev
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
// This test verifies usage of block_load/block_store for local_accessor.
Expand Down
3 changes: 2 additions & 1 deletion sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
//
//===----------------------------------------------------------------------===//
// REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677
//
// XFAIL: igc-dev
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//
Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
//===----------------------------------------------------------------------===//
// REQUIRES: arch-intel_gpu_pvc || gpu-intel-dg2
// REQUIRES-INTEL-DRIVER: lin: 26690, win: 101.4576
// XFAIL: igc-dev
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

// Waiting for the commit in IGC to be pulled into the driver to resolve the
// test.
// XFAIL: gpu
// XFAIL: !igc-dev || gpu-intel-dg2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YixingZhang007 , XFAIL-TRACKER jira pointed below is submitted against PVC issue, that you fixed. If test is passing on PVC and is failing on DG2, it should be different jira, since problem is different. Could you please update xfail tracker?

Copy link
Contributor

@YixingZhang007 YixingZhang007 Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure! I will create a new Jira issue regarding this and update the tracker :)

// XFAIL-TRACKER: CMPLRLLVM-63710

#include "common.hpp"
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

// Waiting for the commit in IGC to be pulled into the driver to resolve the
// test.
// XFAIL: gpu
// XFAIL: !igc-dev || gpu-intel-dg2
// XFAIL-TRACKER: CMPLRLLVM-63710

#include "common.hpp"
Expand Down
Loading