Skip to content

Conversation

bb-sycl
Copy link
Contributor

@bb-sycl bb-sycl commented Dec 10, 2024

Scheduled drivers uplift

@bb-sycl bb-sycl requested a review from a team as a code owner December 10, 2024 03:19
@bader
Copy link
Contributor

bader commented Dec 17, 2024

@intel/dpcpp-devops-reviewers, ping.

@sarnex
Copy link
Contributor

sarnex commented Dec 17, 2024

Sorry, forgot to assign myself. the IGC CI was totally busted, I had to fix it myself and now it's somewhat working, will work on this.

@sarnex sarnex self-assigned this Dec 17, 2024
@sarnex sarnex closed this Dec 17, 2024
@sarnex sarnex reopened this Dec 17, 2024
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex requested review from a team as code owners December 17, 2024 22:13
@sarnex
Copy link
Contributor

sarnex commented Dec 18, 2024

@intel/dpcpp-sanitizers-review Ping, needed to disable some tests that started failing in the GPU driver, please take a look, thanks!

@sarnex sarnex requested a review from uditagarwal97 December 18, 2024 22:21
@sarnex
Copy link
Contributor

sarnex commented Dec 18, 2024

@uditagarwal97 Hey do you mind reviewing the devops changes here? The new stable GPU driver requires Ubuntu 24.04, so we switch to that everywhere we use the driver and update the install driver script to expect 24.04 as well as deal with the current upstream dpkg issues that previously existed in igc-dev but now also exist in stable, it's known upstream already. Thx!

Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devops changes LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@intel/dpcpp-sanitizers-review Ping, needed to disable some tests that started failing in the GPU driver, please take a look, thanks!

@sarnex I'm a bit confused, this is the only change I see since my last review, how does xfailing in CPU relate to problems in the GPU driver?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah youre right this makes no sense, let me remove it try to remember why i added it, thanks

Copy link
Contributor

@sarnex sarnex Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok it took me forever but i investigated it, basically the test calls the gpu driver manually even when the target device is cpu , that's why it's failing, so im gonna add the XFAIL back, idk if thats intentional or not but ill let the test owner investigate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that expected? Should we rewrite the test not to do that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, theres a GH issue tracking the XFAIL so i'll let the issue owner make a decision

Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to ignore postcommit (its using the wrong image) failures and dev igc failures (installing wrong driver)

@sarnex sarnex merged commit 09df9a6 into sycl Dec 19, 2024
27 of 31 checks passed
@bader bader deleted the ci/update_gpu_driver-linux-24.45.31740.9 branch December 20, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants