-
Notifications
You must be signed in to change notification settings - Fork 791
[GHA] Uplift Linux GPU RT version to 24.45.31740.9 #16312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9c2ac0a
[GHA] Uplift Linux GPU RT version to 24.45.31740.9
actions-user d81751a
fix igc dep
sarnex b9cbd1b
use 24.04
sarnex 4f3e923
Merge remote-tracking branch 'upstream/sycl' into ci/update_gpu_drive…
sarnex 7038aff
script
sarnex 659a737
fix script again
sarnex a5d2742
disable failing tests
sarnex 7a7ded1
missed jobs
sarnex a7aba9a
fix test
sarnex 2985507
Merge remote-tracking branch 'upstream/sycl' into ci/update_gpu_drive…
sarnex 6ec0ea9
remove cpu xfail
sarnex e720b1e
Merge remote-tracking branch 'upstream/sycl' into ci/update_gpu_drive…
sarnex dd8aaff
remove xfail
sarnex 3281e37
xfail
sarnex 1171989
readd xfail
sarnex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarnex I'm a bit confused, this is the only change I see since my last review, how does xfailing in CPU relate to problems in the GPU driver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah youre right this makes no sense, let me remove it try to remember why i added it, thanks
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok it took me forever but i investigated it, basically the test calls the gpu driver manually even when the target device is cpu , that's why it's failing, so im gonna add the XFAIL back, idk if thats intentional or not but ill let the test owner investigate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that expected? Should we rewrite the test not to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea, theres a GH issue tracking the XFAIL so i'll let the issue owner make a decision