Skip to content
2 changes: 1 addition & 1 deletion sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// REQUIRES: opencl, opencl_icd, cm-compiler
// XFAIL: gpu
// XFAIL: gpu || cpu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@intel/dpcpp-sanitizers-review Ping, needed to disable some tests that started failing in the GPU driver, please take a look, thanks!

@sarnex I'm a bit confused, this is the only change I see since my last review, how does xfailing in CPU relate to problems in the GPU driver?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah youre right this makes no sense, let me remove it try to remember why i added it, thanks

Copy link
Contributor

@sarnex sarnex Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok it took me forever but i investigated it, basically the test calls the gpu driver manually even when the target device is cpu , that's why it's failing, so im gonna add the XFAIL back, idk if thats intentional or not but ill let the test owner investigate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that expected? Should we rewrite the test not to do that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, theres a GH issue tracking the XFAIL so i'll let the issue owner make a decision

// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16406
// RUN: %{build} -Wno-error=deprecated-declarations -DRUN_KERNELS %opencl_lib -o %t.out
// RUN: %{run} %t.out
Expand Down
Loading