[NFCI][SYCL] Refactor named swizzles implementation #16354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
requested review from
KseniyaTikhomirova,
steffenlarsen and
uditagarwal97
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
commented
Dec 12, 2024
sycl/include/sycl/vector.hpp
Outdated
Contributor
Author
There was a problem hiding this comment.
I'm using "Both" vs "Const" here because that's what existing implementation does. Per the specification it should be const only version - to be cleaned up separately under -fpreview-breaking-changes.
aelovikov-intel
force-pushed
the
named-swizzles-mixin
branch
from
1aaa7b6 to
ce49062
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Instead of using preprocessor via `swizzles.def` file that is included multiple times, employ mixin-based approach which is more C++'ish.
aelovikov-intel
force-pushed
the
named-swizzles-mixin
branch
from
ce49062 to
8357b6b
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-reviewers-runtime , ping. |
# Conflicts: # sycl/test/check_device_code/vector/vector_bf16_builtins.cpp # sycl/test/check_device_code/vector/vector_convert_bfloat.cpp # sycl/test/check_device_code/vector/vector_math_ops.cpp
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using preprocessor via
swizzles.deffile that is includedmultiple times, employ mixin-based approach which is more C++'ish.