Skip to content

[SYCL][E2E] Fix E2E tests passing on PVC + L0 after driver uplift #16551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 13, 2025
Merged

[SYCL][E2E] Fix E2E tests passing on PVC + L0 after driver uplift #16551

merged 7 commits into from
Jan 13, 2025

Conversation

@uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Jan 8, 2025 •
edited by dm-vodopyanov
Loading

partially address #16401

@uditagarwal97 uditagarwal97 self-assigned this Jan 8, 2025
@uditagarwal97 uditagarwal97 requested review from a team as code owners January 8, 2025 01:39
dkhaldi
dkhaldi approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JM changes look good to me.

@uditagarwal97 uditagarwal97 marked this pull request as draft January 8, 2025 02:17
@maarquitos14
Copy link
Contributor

maarquitos14 commented Jan 8, 2025

I see some of the tests are actually failing in PVC after your changes, do we know why?

@uditagarwal97 uditagarwal97 marked this pull request as ready for review January 8, 2025 22:18
@uditagarwal97
Copy link
Contributor Author

uditagarwal97 commented Jan 8, 2025

I see some of the tests are actually failing in PVC after your changes, do we know why?

Yes, some tests are still failing on opencl - I've enabled these tests for L0 atleast. Some ProgramManager tests were failing due to CI issue and they were fixed in #16562

@uditagarwal97 uditagarwal97 changed the title [SYCL][E2E] Remove XFAIL from E2E tests passing on PVC after driver uplift [SYCL][E2E] Fix E2E tests passing on PVC + L0 after driver uplift Jan 8, 2025
@uditagarwal97
Copy link
Contributor Author

uditagarwal97 commented Jan 9, 2025

Ping @intel/syclcompat-lib-reviewers @intel/dpcpp-sanitizers-review

@uditagarwal97
Copy link
Contributor Author

uditagarwal97 commented Jan 10, 2025

@intel/dpcpp-sanitizers-review Ping x2

@uditagarwal97
Copy link
Contributor Author

uditagarwal97 commented Jan 13, 2025

@intel/llvm-gatekeepers the PR is ready to be merged.

@sarnex sarnex merged commit 3abd321 into sycl Jan 13, 2025
17 checks passed
@bader bader deleted the pvc_xfail branch January 14, 2025 05:01
@VyacheslavLevytskyy
Copy link
Contributor

VyacheslavLevytskyy commented Jan 16, 2025

@uditagarwal97 I think that sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp may be a flaky test. I've seen it succeeded and failed after I re-run CI.

@uditagarwal97
Copy link
Contributor Author

uditagarwal97 commented Jan 16, 2025

@uditagarwal97 I think that sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp may be a flaky test. I've seen it succeeded and failed after I re-run CI.

PR to disable this test: #16664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@sarnex sarnex sarnex approved these changes

@dkhaldi dkhaldi dkhaldi approved these changes

@maarquitos14 maarquitos14 maarquitos14 approved these changes

@yingcong-wu yingcong-wu yingcong-wu approved these changes

+1 more reviewer

@JackAKirk JackAKirk JackAKirk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@uditagarwal97 uditagarwal97

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@uditagarwal97 @maarquitos14 @VyacheslavLevytskyy @cperkinsintel @sarnex @dkhaldi @JackAKirk @yingcong-wu