Skip to content

[SYCL][E2E] Fix E2E tests passing on PVC + L0 after driver uplift #16551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 13, 2025
Merged

[SYCL][E2E] Fix E2E tests passing on PVC + L0 after driver uplift #16551

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a484e53
Remove XFAIL for tests passing on PVC
uditagarwal97 Jan 8, 2025
e8b2be9
Remove XFAIL tracker
uditagarwal97 Jan 8, 2025
cff47ed
XFAIL some tests failing on opencl
uditagarwal97 Jan 8, 2025
0055d40
Merge remote-tracking branch 'origin/sycl' into HEAD
uditagarwal97 Jan 8, 2025
0f3174a
Disable MemorySanitizer tests on PVC igc-dev
uditagarwal97 Jan 8, 2025
4272f7c
Remove whiteline
uditagarwal97 Jan 8, 2025
57491bf
Mark device_architecture_comparison_on_device_aot test XFAIL on PVC,i…
uditagarwal97 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
// REQUIRES: arch-intel_gpu_pvc, ocloc

// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401

// RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_pvc %s -o %t.out
// RUN: %{run} %t.out

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/DeviceCodeSplit/grf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
// compiler option

// REQUIRES: arch-intel_gpu_pvc
// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401

// RUN: %{build} -Wno-error=deprecated-declarations -o %t1.out
// RUN: env SYCL_UR_TRACE=2 %{run} %t1.out 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-NO-VAR
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelAndProgram/persistent-cache-multi-device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
// RUN: env NEOReadDebugKeys=1 CreateMultipleRootDevices=3 SYCL_CACHE_PERSISTENT=1 SYCL_CACHE_TRACE=1 SYCL_CACHE_DIR=%t/cache_dir env -u XDG_CACHE_HOME env -u HOME %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-BUILD
// RUN: env NEOReadDebugKeys=1 CreateMultipleRootDevices=3 SYCL_CACHE_PERSISTENT=1 SYCL_CACHE_TRACE=1 SYCL_CACHE_DIR=%t/cache_dir env -u XDG_CACHE_HOME env -u HOME %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-CACHE

// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401

// Test checks that persistent cache works correctly with multiple devices.

#include <sycl/detail/core.hpp>
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

// Waiting for the commit in IGC to be pulled into the driver to resolve the
// test.
// XFAIL: (!igc-dev || gpu-intel-dg2) && run-mode
// XFAIL: gpu-intel-dg2 && run-mode
// XFAIL-TRACKER: GSD-10510

#include "common.hpp"
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

// Waiting for the commit in IGC to be pulled into the driver to resolve the
// test.
// XFAIL: (!igc-dev || gpu-intel-dg2) && run-mode
// XFAIL: gpu-intel-dg2 && run-mode
// XFAIL-TRACKER: GSD-10510

#include "common.hpp"
Expand Down
7 changes: 3 additions & 4 deletions sycl/test-e2e/MemorySanitizer/lit.local.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# TRACKER: https://github.com/intel/llvm/issues/16184
# TRACKER for PVC: https://github.com/intel/llvm/issues/16401
#has_arch_gpu_intel_pvc = any('arch-intel_gpu_pvc' in T for T in config.sycl_dev_features.values())
#if not has_arch_gpu_intel_pvc:
config.unsupported_features += ['gpu']
has_arch_gpu_intel_pvc = any('arch-intel_gpu_pvc' in T for T in config.sycl_dev_features.values())
if not has_arch_gpu_intel_pvc:
config.unsupported_features += ['gpu']

config.substitutions.append(
("%device_msan_flags", "-Xarch_device -fsanitize=memory")
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/ProgramManager/multi_device_bundle/build_twice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 CreateMultipleRootDevices=3 SYCL_UR_TRACE=2 %{run} %t.out | FileCheck %s

// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401

#include <sycl/detail/core.hpp>
#include <sycl/kernel_bundle.hpp>

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/ProgramManager/multi_device_bundle/device_libs_and_caching.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@
// Check the case when in-memory caching of the programs is disabled.
// RUN: env SYCL_CACHE_IN_MEM=0 NEOReadDebugKeys=1 CreateMultipleRootDevices=4 %{run} %t.out

// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401

#include <cmath>
#include <complex>
#include <sycl/detail/core.hpp>
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/Regression/multithread_write_accessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// RUN: %{build} -o %t.out %threads_lib
// RUN: %{run} %t.out

// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401

#include <sycl/detail/core.hpp>

#include <cassert>
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/syclcompat/launch/launch_policy_lmem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@
// UNSUPPORTED: linux && opencl && (gpu-intel-gen12 || gpu-intel-dg2)
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/15275

// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401

#include <sycl/detail/core.hpp>
#include <sycl/ext/oneapi/properties/properties.hpp>
#include <sycl/group_barrier.hpp>
Expand Down
Loading