[CI] Fix driver update script with IGC #16647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
bader
approved these changes
Jan 15, 2025
| config[platform_tag]['igc']['version'] = ver | ||
| config[platform_tag]['igc']['url'] = 'https://github.com/intel/intel-graphics-compiler/releases/tag/igc-' + ver | ||
| break | ||
| m = re.search( |
There was a problem hiding this comment.
I hope that NEO team will not put into their release notes something like:
Do NOT use latest https://github.com/intel/intel-graphics-compiler/releases/tag/. It's broken ...
Use https://github.com/intel/intel-graphics-compiler/releases/tag/ instead.
:)
There was a problem hiding this comment.
lol yeah that would be painful
uditagarwal97
approved these changes
Jan 15, 2025
| m = re.search( | ||
| re.escape("https://github.com/intel/intel-graphics-compiler/releases/tag/") | ||
| + r"(v[\.0-9]+)", | ||
| compute_runtime["body"], |
There was a problem hiding this comment.
Is this idiomatic python to have that trailing comma before the closing )?
There was a problem hiding this comment.
i didnt have this originally but the format ci job told me to add it, so i guess yes?
https://github.com/intel/llvm/actions/runs/12793137909/job/35665241206
aelovikov-intel
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of things changed that cause the script to break:
.sumfile in thecompute-runtimerelease no longer lists IGC debs.Update the script to find the IGC tag using a regex in the
compute-runtimerelease description, which is the only place that lists the corresponding IGC version.