Skip to content

[CI] Fix driver update script with IGC #16647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[CI] Fix driver update script with IGC #16647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions devops/scripts/update_drivers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,18 @@ def uplift_linux_igfx_driver(config, platform_tag, igc_dev_only):
config[platform_tag]['compute_runtime']['version'] = compute_runtime['tag_name']
config[platform_tag]['compute_runtime']['url'] = 'https://github.com/intel/compute-runtime/releases/tag/' + compute_runtime['tag_name']

for a in compute_runtime['assets']:
if a['name'].endswith('.sum'):
deps = str(urlopen(a['browser_download_url']).read())
m = re.search(r"intel-igc-core_([0-9\.]*)_amd64", deps)
if m is not None:
ver = m.group(1)
config[platform_tag]['igc']['github_tag'] = 'igc-' + ver
config[platform_tag]['igc']['version'] = ver
config[platform_tag]['igc']['url'] = 'https://github.com/intel/intel-graphics-compiler/releases/tag/igc-' + ver
break
m = re.search(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that NEO team will not put into their release notes something like:

Do NOT use latest https://github.com/intel/intel-graphics-compiler/releases/tag/. It's broken ...
Use https://github.com/intel/intel-graphics-compiler/releases/tag/ instead.

:)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yeah that would be painful

re.escape("https://github.com/intel/intel-graphics-compiler/releases/tag/")
+ r"(v[\.0-9]+)",
compute_runtime["body"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this idiomatic python to have that trailing comma before the closing )?

Copy link
Contributor Author

@sarnex sarnex Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didnt have this originally but the format ci job told me to add it, so i guess yes?

https://github.com/intel/llvm/actions/runs/12793137909/job/35665241206

)
if m is not None:
ver = m.group(1)
config[platform_tag]["igc"]["github_tag"] = ver
config[platform_tag]["igc"]["version"] = ver
config[platform_tag]["igc"]["url"] = (
"https://github.com/intel/intel-graphics-compiler/releases/tag/" + ver
)

cm = get_latest_release('intel/cm-compiler')
config[platform_tag]['cm']['github_tag'] = cm['tag_name']
Expand Down
Loading