[CI] Install spirv-tools on Linux docker containers
#16724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to improve test coverage as some `llvm-spriv` tests require `spirv-tools` to execute.
uditagarwal97
changed the title
spriv-tools on Linux docker containersspirv-tools on Linux docker containers
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Jan 22, 2025
| # https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/cec12d6cf46306d0a015e883d5adb5a8200df1c0/.github/workflows/check-out-of-tree-build.yml#L59 | ||
| . /etc/os-release | ||
| curl -L "https://packages.lunarg.com/lunarg-signing-key-pub.asc" | apt-key add - | ||
| echo "deb https://packages.lunarg.com/vulkan $VERSION_CODENAME main" | sudo tee -a /etc/apt/sources.list |
There was a problem hiding this comment.
we can probably remove sudo after the | because all the other commands assume current user is root
uditagarwal97
commented
Jan 22, 2025
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers I think we are good to merge this - the on-going/pending checks can be ignored as the change is in docker container only. |
|
IGC dev CI container build failure is unrelated. |
uditagarwal97
added a commit
that referenced
this pull request
Jan 22, 2025
This reverts commit 34ef866.
This was referenced Jan 22, 2025
sarnex
pushed a commit
that referenced
this pull request
Jan 23, 2025
#16724 installed `spirv-tools` on Linux docker containers and now some llvm-spirv tests are failing due to this (example: https://github.com/intel/llvm/actions/runs/12915358763/job/36017038536). In this PR, we disable detection of `spirv-tools` LIT feature temporarily in CI to fix post-commit. --------- Co-authored-by: Marcos Maronas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to improve test coverage as some
llvm-spirvtests requirespirv-toolsto execute.