Skip to content

[SYCL] Unify SPIR/non-SPIR paths for atomic_ref ctor #17196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

[SYCL] Unify SPIR/non-SPIR paths for atomic_ref ctor #17196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions sycl/include/sycl/atomic_ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,16 +158,9 @@ class atomic_ref_base {
}

#ifdef __SYCL_DEVICE_ONLY__
#if defined(__SPIR__)
explicit atomic_ref_base(T &ref)
: ptr(ext::oneapi::experimental::static_address_cast<AddressSpace>(
&ref)) {}
#else
// CUDA/HIP don't support `ext::oneapi::experimental::static_address_cast`
// yet.
explicit atomic_ref_base(T &ref)
: ptr(address_space_cast<AddressSpace, access::decorated::no>(&ref)) {}
#endif
#else
// FIXME: This reinterpret_cast is UB, but happens to work for now
explicit atomic_ref_base(T &ref)
Expand Down
Loading