[SYCL] logical operation return type is boolean #17239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
HPS-1
approved these changes
Mar 13, 2025
Contributor
HPS-1
left a comment
HPS-1
left a comment
There was a problem hiding this comment.
Not sure why is TEST_VOID_TYPES added? I mean I think we can just run tests for void and non-void versions together. This we we only need 2 instead of 4 runs in total. Other than this small issue I believe you've addressed all the comments. LGTM!
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@aelovikov-intel Please, review it |
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Co-authored-by: Steffen Larsen <[email protected]>
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix to return boolean value type of
logical_and/logical_oraccording toKhronosGroup/SYCL-Docs#648
CTS changes will be done in a separate PR