-
Notifications
You must be signed in to change notification settings - Fork 794
[SYCL] logical operation return type is boolean #17239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aelovikov-intel
merged 9 commits into
intel:sycl
from
dklochkov-emb:sycl-logical-operations-return-type
Apr 22, 2025
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
48153fb
[SYCL] logical operation return type is boolean
dklochkov-emb b6df1d9
[SYCL] update test to check void types
dklochkov-emb 0c4d352
[SYCL] simplify changes
dklochkov-emb b1d3543
[SYCL] crate separate negative test for logical operations with type …
dklochkov-emb df2fcb2
[SYCL] update formatting
dklochkov-emb fe3b943
[SYCL] simplify expression to test logfical operations with void types
dklochkov-emb 89462df
[SYCL] avoid true in test expressions
dklochkov-emb 025456a
[SYCL] do not create separate test for void types
dklochkov-emb b800256
[SYCL] use -fsynatx-only
dklochkov-emb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // RUN: %clang -D__INTEL_PREVIEW_BREAKING_CHANGES -fsycl -o - %s | ||
dklochkov-emb marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| // RUN: %clang -fsycl -o - %s | ||
dklochkov-emb marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| #include <cassert> | ||
| #include <sycl/functional.hpp> | ||
| #include <type_traits> | ||
|
|
||
| int main() { | ||
| const auto logicalAnd = sycl::logical_and<int>(); | ||
dklochkov-emb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const auto logicalOr = sycl::logical_or<int>(); | ||
| #ifdef __INTEL_PREVIEW_BREAKING_CHANGES | ||
| static_assert(std::is_same_v<decltype(logicalAnd(1, 2)), bool> == true); | ||
| static_assert(std::is_same_v<decltype(logicalOr(1, 2)), bool> == true); | ||
| #else | ||
| static_assert(std::is_same_v<decltype(logicalAnd(1, 2)), int> == true); | ||
| static_assert(std::is_same_v<decltype(logicalOr(1, 2)), int> == true); | ||
dklochkov-emb marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| #endif | ||
| return 0; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.