[UR][L0 v2] Bindless images implementation #17292
Conversation
|
[WIP] Partial implementation of bindless images in L0 V2 adapter, 20/22 SYCL bindless images tests passed (36 unsupported, both in v1 and v2). |
unified-runtime/source/adapters/level_zero/v2/queue_immediate_in_order.cpp
Outdated
Show resolved
Hide resolved
…cpp) integrated, bindless version removed
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
There was a problem hiding this comment.
I think the naming here could be improved. Inside this function it is processing the copy requested, calling the approperate UR copy functions. Maybe bindlessImagesProcessCopy is better?
What do you think?
| #include <loader/ze_loader.h> | ||
|
|
||
| #include "common.hpp" | ||
| #ifdef UR_ADAPTER_LEVEL_ZERO_V2 |
There was a problem hiding this comment.
Same. I am worried about this sharing of code between the V1 and V2 L0 adaptors. But should be ok as long as both adapter versions are ran in CI till the moveover to the V2 adaptor is finished.
Thanks, good to know. What are the two tests not passing in v2 that pass in v1? |
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@intel/llvm-gatekeepers this is ready to merge |
6 participants
Bindless images functions ported from v1 to v2