Skip to content

[UR][L0 v2] Bindless images implementation #17292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Apr 25, 2025
Merged

[UR][L0 v2] Bindless images implementation #17292

Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
db178ef
[UR] option to build UR with level_zero_v2 adapter
mateuszpn Feb 20, 2025
e1bd97f
Merge branch 'intel:sycl' into l0v2
mateuszpn Mar 3, 2025
c5090bb
bindless images - create, copy
mateuszpn Mar 3, 2025
de9e8a4
Merge branch 'l0v2' of github.com:mateuszpn/llvm into l0v2
mateuszpn Mar 3, 2025
772b279
bindless images - create, copy data, destroy
mateuszpn Mar 3, 2025
3a602ca
bindless images - further functions (20/22 test passed)
mateuszpn Mar 4, 2025
9c9b89e
Pre-implementation of all needed functions (0 tests failed)
mateuszpn Mar 6, 2025
525829d
ur2zeImageDesc (image_helpers.cpp) and ur2zeImageDescBindless (image.…
mateuszpn Mar 7, 2025
9e1d202
bindless images functions common for v1 & v2 moved to image_common.cpp
mateuszpn Mar 7, 2025
29e507b
fixed usage of handles in v2, refactor
mateuszpn Mar 12, 2025
9da86d1
format fix
mateuszpn Mar 12, 2025
ba96ee7
common functions moved to image_common.cpp
mateuszpn Mar 12, 2025
e2267ae
urBindlessImagesImageGetInfoExp tested and moved to image_common.cpp
mateuszpn Mar 12, 2025
e32f719
urBindlessImagesImageGetInfoExp tested and moved to image_common.cpp
mateuszpn Mar 13, 2025
85cb762
common (v1/v2) bindless img description struct
mateuszpn Mar 13, 2025
e3b020b
Merge branch 'sycl' into l0v2
mateuszpn Mar 13, 2025
8f252bd
format fix
mateuszpn Mar 13, 2025
ec8d16e
Merge branch 'intel:sycl' into l0v2
mateuszpn Mar 14, 2025
e6bd8a6
Merge branch 'intel:sycl' into l0v2
mateuszpn Mar 17, 2025
49c489c
fixes in ur_bindless_mem_handle_t and bindlessImagesImageCopyExp
mateuszpn Mar 17, 2025
30023d3
common image copy logic extracted
mateuszpn Mar 18, 2025
6dd26d9
some funcions moved to anonymous namespace
mateuszpn Mar 18, 2025
7893a10
comments applied
mateuszpn Mar 19, 2025
0a56566
comments cntd
mateuszpn Mar 20, 2025
cbdeab0
Merge branch 'intel:sycl' into l0v2
mateuszpn Mar 20, 2025
cf906bf
all functions implemented in v1 enabled in v2
mateuszpn Mar 24, 2025
295c315
Merge branch 'intel:sycl' into l0v2
mateuszpn Mar 25, 2025
14827d0
Merge branch 'intel:sycl' into l0v2
mateuszpn Mar 26, 2025
e320adf
Comments applied
mateuszpn Mar 27, 2025
f82218c
urBindlessImagesMapExternalLinearMemoryExp made common for v1 & v2
mateuszpn Mar 28, 2025
e31edfc
lock added
mateuszpn Mar 28, 2025
5a90016
Merge remote-tracking branch 'upstream/sycl' into l0v2
mateuszpn Mar 28, 2025
2856929
Merge branch 'intel:sycl' into l0v2
mateuszpn Mar 28, 2025
b051202
minor adjustments for clang
mateuszpn Mar 28, 2025
a354323
Merge branch 'l0v2' of github.com:mateuszpn/llvm into l0v2
mateuszpn Mar 28, 2025
852e27b
integration of image_common and image_helper files
mateuszpn Mar 28, 2025
d5fd1db
comments addressed
mateuszpn Apr 1, 2025
fc881e8
fix of function call
mateuszpn Apr 3, 2025
63f837a
Merge remote-tracking branch 'upstream/sycl' into l0v2
mateuszpn Apr 8, 2025
5a3c00f
Merge remote-tracking branch 'upstream/sycl' into l0v2
mateuszpn Apr 15, 2025
eb723b0
Merge remote-tracking branch 'upstream/sycl' into l0v2
mateuszpn Apr 18, 2025
9f97b4b
Merge remote-tracking branch 'upstream/sycl' into l0v2
mateuszpn Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sycl/test-e2e/bindless_images/lit.local.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# Support of this feature is waiting for the upstream PR
# https://github.com/llvm/llvm-project/pull/127737 to be merged with intel/llvm.
config.unsupported_features += ['spirv-backend']
# V2 adapter does not support bindless images yet
config.unsupported_features += ['level_zero_v2_adapter']
9 changes: 5 additions & 4 deletions unified-runtime/source/adapters/level_zero/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ if(UR_BUILD_ADAPTER_L0)
${CMAKE_CURRENT_SOURCE_DIR}/context.hpp
${CMAKE_CURRENT_SOURCE_DIR}/device.hpp
${CMAKE_CURRENT_SOURCE_DIR}/event.hpp
${CMAKE_CURRENT_SOURCE_DIR}/image_common.hpp
${CMAKE_CURRENT_SOURCE_DIR}/usm.hpp
${CMAKE_CURRENT_SOURCE_DIR}/memory.hpp
${CMAKE_CURRENT_SOURCE_DIR}/kernel.hpp
Expand All @@ -28,7 +29,6 @@ if(UR_BUILD_ADAPTER_L0)
${CMAKE_CURRENT_SOURCE_DIR}/program.hpp
${CMAKE_CURRENT_SOURCE_DIR}/queue.hpp
${CMAKE_CURRENT_SOURCE_DIR}/sampler.hpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/image_helpers.hpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/kernel_helpers.hpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/memory_helpers.hpp
${CMAKE_CURRENT_SOURCE_DIR}/ur_level_zero.cpp
Expand All @@ -48,7 +48,7 @@ if(UR_BUILD_ADAPTER_L0)
${CMAKE_CURRENT_SOURCE_DIR}/queue.cpp
${CMAKE_CURRENT_SOURCE_DIR}/sampler.cpp
${CMAKE_CURRENT_SOURCE_DIR}/image.cpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/image_helpers.cpp
${CMAKE_CURRENT_SOURCE_DIR}/image_common.cpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/kernel_helpers.cpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/memory_helpers.cpp
${CMAKE_CURRENT_SOURCE_DIR}/../../ur/ur.cpp
Expand Down Expand Up @@ -125,20 +125,20 @@ if(UR_BUILD_ADAPTER_L0_V2)
${CMAKE_CURRENT_SOURCE_DIR}/adapter.hpp
${CMAKE_CURRENT_SOURCE_DIR}/common.hpp
${CMAKE_CURRENT_SOURCE_DIR}/device.hpp
${CMAKE_CURRENT_SOURCE_DIR}/image_common.hpp
${CMAKE_CURRENT_SOURCE_DIR}/platform.hpp
${CMAKE_CURRENT_SOURCE_DIR}/physical_mem.hpp
${CMAKE_CURRENT_SOURCE_DIR}/program.hpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/image_helpers.hpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/kernel_helpers.hpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/memory_helpers.hpp
${CMAKE_CURRENT_SOURCE_DIR}/adapter.cpp
${CMAKE_CURRENT_SOURCE_DIR}/common.cpp
${CMAKE_CURRENT_SOURCE_DIR}/device.cpp
${CMAKE_CURRENT_SOURCE_DIR}/image_common.cpp
${CMAKE_CURRENT_SOURCE_DIR}/ur_interface_loader.cpp
${CMAKE_CURRENT_SOURCE_DIR}/platform.cpp
${CMAKE_CURRENT_SOURCE_DIR}/physical_mem.cpp
${CMAKE_CURRENT_SOURCE_DIR}/program.cpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/image_helpers.cpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/kernel_helpers.cpp
${CMAKE_CURRENT_SOURCE_DIR}/helpers/memory_helpers.cpp
${CMAKE_CURRENT_SOURCE_DIR}/usm_p2p.cpp
Expand Down Expand Up @@ -173,6 +173,7 @@ if(UR_BUILD_ADAPTER_L0_V2)
${CMAKE_CURRENT_SOURCE_DIR}/v2/event_provider_counter.cpp
${CMAKE_CURRENT_SOURCE_DIR}/v2/event_provider_normal.cpp
${CMAKE_CURRENT_SOURCE_DIR}/v2/event.cpp
${CMAKE_CURRENT_SOURCE_DIR}/v2/image.cpp
${CMAKE_CURRENT_SOURCE_DIR}/v2/kernel.cpp
${CMAKE_CURRENT_SOURCE_DIR}/v2/memory.cpp
${CMAKE_CURRENT_SOURCE_DIR}/v2/queue_api.cpp
Expand Down
Loading