[UR] Move non-conformance/adapter tests to lit #17580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/morelit
branch
from
b7d3c9d to
6da2652
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
This is a newer version of the PR here. See that for some comments that have hopefully been resolved. |
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/morelit
branch
from
6da2652 to
695f3ae
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Mar 24, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/morelit
branch
from
695f3ae to
341ac9b
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/morelit
branch
from
341ac9b to
8ed0446
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
reviewed
Mar 31, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/morelit
branch
from
8ed0446 to
81317a3
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/morelit
branch
from
81317a3 to
e8ef3a6
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
reviewed
Apr 4, 2025
unified-runtime/test/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Where does add_lit_testing() come from?
There was a problem hiding this comment.
I'm still interested in an answer to this.
There was a problem hiding this comment.
It's a function defined in intel/llvm. If a full LLVM build is available, we use the lit test suite managing thingies from there.
RossBrunton
force-pushed
the
ross/morelit
branch
from
78358b8 to
ee08ff3
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/morelit
branch
from
ee08ff3 to
d51d060
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/morelit
branch
from
d51d060 to
e7bd637
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Apr 8, 2025
unified-runtime/test/CMakeLists.txt
Outdated
There was a problem hiding this comment.
I'm still interested in an answer to this.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
approved these changes
Apr 8, 2025
RossBrunton
force-pushed
the
ross/morelit
branch
from
e7bd637 to
08313ae
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This adds support for lit to unified-runtime, in the form of a new target `check-unified-runtime`. This target is available when UR is built standalone and when built as part of dpcpp. In addition, there are targets like `check-unified-runtime-unit` which run a subset of the lit tests. When built standalone, `lit` and `filecheck` must be avilable in the path. A `requirements_testing.txt` file is available to install test dependencies. When built as part of dpcpp, a new cmake variable is available; `SYCL_UR_BUILD_TESTS` which is off by default. When enabled, `check-unified-runtime` will be available as a target and will also run as part of `check-all`. All tests have been ported with the exception of: * Adapter tests * Conformance tests The Python version for macos was also bumped to 3.10 to enable use of a newer filecheck version.
RossBrunton
force-pushed
the
ross/morelit
branch
from
08313ae to
f7ad045
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers Please merge (unless there's a conflict due to someone updating tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for lit to unified-runtime, in the form
of a new target
check-unified-runtime. This target is availablewhen UR is built standalone and when built as part of dpcpp.
In addition, there are targets like
check-unified-runtime-unitwhich run a subset of the lit tests.
When built standalone,
litandfilecheckmust be avilable inthe path. A
requirements_testing.txtfile is available toinstall test dependencies.
When built as part of dpcpp, a new cmake variable is available;
SYCL_UR_BUILD_TESTSwhich is off by default. When enabled,check-unified-runtimewill be available as a target and willalso run as part of
check-all.All tests have been ported with the exception of:
The Python version for macos was also bumped to 3.10 to enable
use of a newer filecheck version.