[SYCL][Test] Replace multi-device kernel_bundle e2e tests with unit test #17691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
force-pushed
the
replace_with_unit_test
branch
from
2cd5d37 to
d0d6751
Compare
againull
changed the title
Replace the following e2e tests with unit test: ProgramManager/multi_device_bundle~device_libs_and_caching.cpp ProgramManager/multi_device_bundle~build_twice.cpp KernelAndProgram/persistent-cache-multi-device.cpp The reason is that the checks performed in those e2e tests (number of UR calls, etc.) can be done more effificently using unit tests, such checks in e2e tests are expensive. Another reson is that e2e tests use NEO-specific CreateMultipleRootDevices=[num] environment variable which is not guaranteed to work, in unit tests we can emulate as many devices as we want.
againull
force-pushed
the
replace_with_unit_test
branch
from
d0d6751 to
d5495b9
Compare
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
@slawekptak @intel/llvm-reviewers-runtime Could you review please. |
slawekptak
reviewed
Apr 11, 2025
Contributor
slawekptak
left a comment
slawekptak
left a comment
There was a problem hiding this comment.
Just a small thing: This PR also modifies config.hpp. Could you please add a note to the description about this change and how it relates to the changes in tests?
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
Sorry, I've removed that part as I have realized it is excessive. Initially I have added specialization of the SYCLConfig for SYCL_DEVICELIB_NO_FALLBACK to be able to unset that config value from inside the unit test - because I want to test behavior when fallback libs are allowed. Now I've realized that there is a simpler way to do so using existing ScopedEnvVar and by passing nullptr to it (which results in unsetting the value, i.e. same desired behavior). |
againull
changed the title
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
approved these changes
Apr 12, 2025
itt_annotations.cpp contains two unit tests. First one was setting INTEL_ENABLE_OFFLOAD_ANNOTATIONS=1 and didn't restore original value - this is a bug, because there is no guarantee that the first and the second test from this file run in order, google test might run other tests in between. So INTEL_ENABLE_OFFLOAD_ANNOTATIONS=1 was interfering with other tests - the ones which test persistent cache, because INTEL_ENABLE_OFFLOAD_ANNOTATIONS=1 disables persistent cache. So, this commit fixes this behaviour by using scoped env var.
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
If we register an image with device lib extensions then files must already be available. There are some tests in ProgramManager unit test executable which create a kernel bundle withouth specifying particular kernel name, so kernels from all images (from all tests) can be used and must be functional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the following e2e tests with unit test:
The reason is that the checks performed in those e2e tests (number of UR calls, etc.) can be done more effificently using unit tests, such checks in e2e tests are expensive. Another reason is that e2e tests use NEO-specific
CreateMultipleRootDevices=[num]environment variable which is not guaranteed to work, in unit tests we can emulate as many devices as we want.