[SYCL][UR][L0 v2] fix urQueueCreateWithNativeHandle #17784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getSignalEvent in ur_command_list_manager returned nullptr when queue was not set. This was the case when initializing the command list manager in queue ctor called from urQueueCreateWithNativeHandle. Fix this by passing queue to the command list manager and removing the default nullptr value from the ctor (to avoid this issue in future). Also, event if queue is nullptr, return the event instead of nullptr from getSignalEvent. This event is mostly functional, it just cannot be used for profiling.
Contributor
Author
|
@Xewar313 please take a look |
pbalcer
reviewed
Apr 2, 2025
Xewar313
approved these changes
Apr 2, 2025
keyradical
approved these changes
Apr 3, 2025
pbalcer
approved these changes
Apr 3, 2025
Contributor
|
@intel/llvm-gatekeepers please merge |
KornevNikita
pushed a commit
that referenced
this pull request
May 27, 2025
getSignalEvent in ur_command_list_manager returned nullptr when queue was not set. This was the case when initializing the command list manager in queue ctor called from urQueueCreateWithNativeHandle. Fix this by passing queue to the command list manager and removing the default nullptr value from the ctor (to avoid this issue in future). Also, even if queue is nullptr, return the event instead of nullptr from getSignalEvent. This event is mostly functional, it just cannot be used for profiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSignalEvent in ur_command_list_manager returned nullptr when queue was not set. This was the case when initializing the command list manager in queue ctor called from urQueueCreateWithNativeHandle.
Fix this by passing queue to the command list manager and removing the default nullptr value from the ctor (to avoid this issue in future).
Also, even if queue is nullptr, return the event instead of nullptr from getSignalEvent. This event is mostly functional, it just cannot be used for profiling.