[CI] Disable assertions for linux_shared_build in sycl-linux-build.yml

[ianayl]

This PR addresses #17609, which introduces --no-assertions for the archive sprod_shared/linux_shared_build.

This archive is currently not used anywhere: The intention is that we could leverage it for CI runs where performance matters (e.g. benchmarking).

[uditagarwal97]

FYI:- You could use ${{ inputs.build_configure_extra_args }} to pass --no-assertion flag

[ianayl]

FYI:- You could use ${{ inputs.build_configure_extra_args }} to pass --no-assertion flag

My assumption here is that we actually want assertions to be disabled by default: If we make it a part of build_configure_extra_args, wouldn't the user now have to (remember to) add --no-assertions everytime?

Unless this is what we intended, then I'll go ahead and add it to build_configure_extra_args

[uditagarwal97]

FYI:- You could use ${{ inputs.build_configure_extra_args }} to pass --no-assertion flag

My assumption here is that we actually want assertions to be disabled by default: If we make it a part of build_configure_extra_args, wouldn't the user now have to (remember to) add --no-assertions everytime?

Unless this is what we intended, then I'll go ahead and add it to build_configure_extra_args

#17616 (comment)
Nope, we want to have assertions enabled by default. We only have to disable Assertions for sycl toolchain we use to build and run benchmarks.

[ianayl]

FYI:- You could use ${{ inputs.build_configure_extra_args }} to pass --no-assertion flag

My assumption here is that we actually want assertions to be disabled by default: If we make it a part of build_configure_extra_args, wouldn't the user now have to (remember to) add --no-assertions everytime?
Unless this is what we intended, then I'll go ahead and add it to build_configure_extra_args

#17616 (comment) Nope, we want to have assertions enabled by default. We only have to disable Assertions for sycl toolchain we use to build and run benchmarks.

Oh crap... thanks for the catch, I better go revert that then 😅

[uditagarwal97]

LGTM.
@sarnex thoughts?

[uditagarwal97]

Suggested change

	# Build used for performance testing only: not intended for testing
	# Shared lib build is used for performance benchmarking that's why building with --no-assertions.

Something like that.

[sarnex]

nobody uses the shared library build so lgtm