Skip to content

[CI] Disable assertions for linux_shared_build in sycl-linux-build.yml #17894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025
Merged

[CI] Disable assertions for linux_shared_build in sycl-linux-build.yml #17894

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b38da4
Disable asserts in sycl-linux-build by default
ianayl Apr 7, 2025
9cfc165
Revert "Disable asserts in sycl-linux-build by default"
ianayl Apr 7, 2025
0b11964
Disable assertions for linux_shared_build
ianayl Apr 7, 2025
fe414c3
Fix erroneous --no-assert
ianayl Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/sycl-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
# prefer widespread gzip compression.
artifact_archive_name: sycl_linux.tar.gz

# Build used for performance testing only: not intended for testing
Copy link
Contributor

@uditagarwal97 uditagarwal97 Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Build used for performance testing only: not intended for testing
# Shared lib build is used for performance benchmarking that's why building with --no-assertions.

Something like that.

linux_shared_build:
if: github.repository == 'intel/llvm'
uses: ./.github/workflows/sycl-linux-build.yml
Expand All @@ -31,7 +32,7 @@ jobs:
build_cache_root: "/__w/"
build_cache_suffix: sprod_shared
build_artifact_suffix: sprod_shared
build_configure_extra_args: '--shared-libs --hip --cuda --native_cpu'
build_configure_extra_args: '--shared-libs --hip --cuda --native_cpu --no-assertions'

artifact_archive_name: sycl_linux_shared.tar.zst

Expand Down