[SYCL] Remove SYCL_USE_NATIVE_FP_ATOMICS macro
#19962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyniols
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
dyniols
changed the title
SYCL_USE_NATIVE_FP_ATOMICS macroSYCL_USE_NATIVE_FP_ATOMICS macro
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@bader FYI |
aelovikov-intel
approved these changes
Sep 3, 2025
bader
approved these changes
Sep 3, 2025
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Sep 4, 2025
| const llvm::Triple &Triple = TI.getTriple(); | ||
| const llvm::Triple::SubArchType SubArch = Triple.getSubArch(); | ||
| if (Triple.isNVPTX() || Triple.isAMDGPU() || | ||
| (Triple.isSPIR() && SubArch != llvm::Triple::SPIRSubArch_fpga) || |
There was a problem hiding this comment.
Makes me wonder if there is more llvm::Triple::SPIRSubArch_fpga-specific behavior in the frontend/driver that we can get rid of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
SYCL_USE_NATIVE_FP_ATOMICSmacro.It's removed because we don't support FPGA anymore and macro was defined for all target except FPGA.
llvm/clang/lib/Frontend/InitPreprocessor.cpp
Lines 1548 to 1551 in 45cf443