[SYCL][E2E] Improve bindless image copy tests #20000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were made more informative by printing information about a test case and mismatched data on failure. This is done to speed up and simplify failure analysis.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Sep 9, 2025
| validated = false; | ||
| } | ||
|
|
||
| return validated; |
There was a problem hiding this comment.
Alternatively, we could make validated an int, increment it on failure and return it. That could be the value returned by the main function too. Effectively also lets us count the number of failures. It is minor though.
I can submit a follow-up PR which introduces failure counter, but I find it less useful to know how many sub-tests failed vs knowing which sub-tests failed, so I will proceed with the merge as-is for now. |
AlexeySachkov
deleted the
private/asachkov/refactor-some-bindless-image-copy-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were made more informative by printing information about a test case and mismatched data on failure.
This is done to speed up and simplify failure analysis.