[UR][Offload] Sync queues before destroying them #20098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urQueueRelease now waits for all work in the queue to complete, which is consistent with other plugins.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
reviewed
Sep 16, 2025
| break; | ||
| } | ||
| OL_RETURN_ON_ERR(olSyncQueue(Q)); | ||
| OL_RETURN_ON_ERR(olDestroyQueue(Q)); |
There was a problem hiding this comment.
It would be less error-prone for the plugins to do synchronization as part of destroy implicitly. So I think we should change this in liboffload.
But lgtm for now to unblock testing.
There was a problem hiding this comment.
Not syncing was an intentional design decision. It allows queue objects to be created and destroyed for a single operation without requiring the liboffload user to track lifetimes of each queue object.
pbalcer
approved these changes
Sep 16, 2025
|
@intel/llvm-gatekeepers Should be mergable. The offload backend isn't checked as part of any of the failing CI, so these failures are unrelated. |
YixingZhang007
pushed a commit
to YixingZhang007/llvm
that referenced
this pull request
Sep 22, 2025
urQueueRelease now waits for all work in the queue to complete, which is consistent with other plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urQueueRelease now waits for all work in the queue to complete, which
is consistent with other plugins.