Skip to content

[UR][Offload] Sync queues before destroying them #20098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

[UR][Offload] Sync queues before destroying them #20098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions unified-runtime/source/adapters/offload/queue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urQueueRelease(ur_queue_handle_t hQueue) {
if (!Q) {
break;
}
OL_RETURN_ON_ERR(olSyncQueue(Q));
OL_RETURN_ON_ERR(olDestroyQueue(Q));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be less error-prone for the plugins to do synchronization as part of destroy implicitly. So I think we should change this in liboffload.
But lgtm for now to unblock testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not syncing was an intentional design decision. It allows queue objects to be created and destroyed for a single operation without requiring the liboffload user to track lifetimes of each queue object.

}
delete hQueue;
Expand Down
Loading