-
Notifications
You must be signed in to change notification settings - Fork 792
[CI] Remove dependency on bot user for uploading benchmark CI results #20333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ianayl
wants to merge
14
commits into
sycl
Choose a base branch
from
ianayl/benchmark-ci-no-botuser
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
df8990c
test pushing to branch
ianayl 7ce4420
give write permissions
ianayl 866b64e
amend perms
ianayl b518e18
Revert "amend perms"
ianayl 2109b73
Revert "give write permissions"
ianayl 6e73cf7
test perms
ianayl e20975f
typo
ianayl 3bea805
more perms
ianayl 418bd1d
test fail
ianayl 1539867
set to correct repo
ianayl 8e1f1b8
switch branch
ianayl 66c4b5c
try removing manually passing secrets
ianayl baf64ef
fix typo
ianayl ac56a43
make write permissions job-level
ianayl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -134,9 +134,10 @@ runs: | |
|
||
cd - | ||
- name: Checkout results repo | ||
shell: bash | ||
run: | | ||
git clone -b unify-ci https://github.com/intel/llvm-ci-perf-results | ||
uses: actions/checkout@v5 | ||
with: | ||
ref: benchmark-ci-results | ||
ianayl marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
path: llvm-ci-perf-results | ||
- name: Run compute-benchmarks | ||
env: | ||
# Need to append "_<device>_<backend>" to save name in order to follow | ||
|
@@ -237,9 +238,8 @@ runs: | |
shell: bash | ||
run: | | ||
cd "./llvm-ci-perf-results" | ||
git config user.name "SYCL Benchmarking Bot" | ||
git config user.email "[email protected]" | ||
results_branch="unify-ci" | ||
git config user.name "github-actions[bot]" | ||
git config user.email "github-actions[bot]@users.noreply.github.com" | ||
|
||
if git diff --quiet && git diff --cached --quiet; then | ||
echo "No new results added, skipping push." | ||
|
@@ -252,7 +252,7 @@ runs: | |
git commit -m "[GHA] Upload compute-benchmarks results from https://github.com/intel/llvm/actions/runs/${{ github.run_id }}" | ||
results_file="$(git diff HEAD~1 --name-only -- results/ | head -n 1)" | ||
|
||
if git push "https://[email protected]/intel/llvm-ci-perf-results.git" "$results_branch"; then | ||
if git push; then | ||
ianayl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
echo "Push succeeded" | ||
break | ||
fi | ||
|
@@ -262,8 +262,8 @@ runs: | |
cached_result="$(mktemp -d)/$(basename $results_file)" | ||
mv "$results_file" "$cached_result" | ||
|
||
git reset --hard "origin/$results_branch" | ||
git pull origin "$results_branch" | ||
git reset --hard "origin/benchmark-ci-results" | ||
git pull | ||
|
||
mv "$cached_result" "$results_file" | ||
fi | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.