[NFC][E2E] Remove usage of %T in tests #20343
Conversation
%T support is removed in community llvm/llvm-project@7ff6973f1 Use %t.dir instead, create the dir manually.
| // RUN: %clangxx --offload-new-driver %{dynamic_lib_options} %S/Inputs/c.cpp %if windows %{%T/libdevice_d.lib%} -o %T/libdevice_c.%{dynamic_lib_suffix} | ||
| // RUN: %clangxx --offload-new-driver %{dynamic_lib_options} %S/Inputs/b.cpp %if windows %{%T/libdevice_c.lib%} -o %T/libdevice_b.%{dynamic_lib_suffix} | ||
| // RUN: %clangxx --offload-new-driver %{dynamic_lib_options} %S/Inputs/a.cpp %if windows %{%T/libdevice_b.lib%} -o %T/libdevice_a.%{dynamic_lib_suffix} | ||
| // DEFINE: %{tdir} = %t/.. |
There was a problem hiding this comment.
Why not %t.dir here?
There was a problem hiding this comment.
Used %t.dir at first, these 4 tests are failing. I think it is because the following run assume the shared lib in the same folder as %t, so use %t/.. to emulate that.
There was a problem hiding this comment.
@maarquitos14 , do you know what should be changed for those tests to work with %t.dir?
There was a problem hiding this comment.
I'm approving to unblock pulldown, but @maarquitos14 please review/follow-up post-commit.
There was a problem hiding this comment.
I don't, but I'll speak with the team and follow up.
There was a problem hiding this comment.
They all pass locally for me with %t.dir except the compressed one, which I couldn't try because I don't have zstd. Did you try locally @jsji? Or was it the CI that failed?
There was a problem hiding this comment.
I didn't try locally, they were failing in CI.
There was a problem hiding this comment.
Okay, once we have this merged I'll open a PR with them using %t.dir to see if they pass or fail CI, and if they still fail I'll try to emulate CI locally.
|
I also think that we should be removing it |
Sure. Done. |
|
@intel/llvm-gatekeepers Can we get this merged? The testing failure is irrelevant and there looks like some CI problem in pvc sycl-rel testing. |
|
@intel/dpcpp-esimd-reviewers review is required. |
5 participants
%T support is removed in community
llvm/llvm-project@7ff6973f1
Use %t.dir instead, create the dir manually.