[Benchmarks] Print all important env vars in debug logs #20415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
approved these changes
Oct 21, 2025
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Print also PATH and LD_LIBRARY_PATH when these are modified in benchmark commands.
| if add_sycl: | ||
| sycl_bin_path = os.path.join(options.sycl, "bin") | ||
| env["PATH"] = sycl_bin_path + os.pathsep + env.get("PATH", "") | ||
| env_vars["PATH"] = sycl_bin_path + os.pathsep + env.get("PATH", "") |
There was a problem hiding this comment.
shouldn't be the same change done above, in line 55
There was a problem hiding this comment.
good catch but this change will be then overwritten by line 66
moreover after this change if something was already in env_vars under PATH or LD_LIBRARY_PATH then it will be lost
maybe:
- call
env.update(env_vars)right after creating env copy - do printing somehow as
env_str = " ".join(f"{key}={env.get(key)}" for key in env_vars.keys() + "LD_LIBRFARY_PATH" + "PATH")
lslusarczyk
requested changes
Oct 21, 2025
| if add_sycl: | ||
| sycl_bin_path = os.path.join(options.sycl, "bin") | ||
| env["PATH"] = sycl_bin_path + os.pathsep + env.get("PATH", "") | ||
| env_vars["PATH"] = sycl_bin_path + os.pathsep + env.get("PATH", "") |
There was a problem hiding this comment.
good catch but this change will be then overwritten by line 66
moreover after this change if something was already in env_vars under PATH or LD_LIBRARY_PATH then it will be lost
maybe:
- call
env.update(env_vars)right after creating env copy - do printing somehow as
env_str = " ".join(f"{key}={env.get(key)}" for key in env_vars.keys() + "LD_LIBRFARY_PATH" + "PATH")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print also PATH and LD_LIBRARY_PATH when these are modified in benchmark commands.