Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions devops/scripts/benchmarks/utils/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ def run(
# order is important, we want provided sycl rt libraries to be first
if add_sycl:
sycl_bin_path = os.path.join(options.sycl, "bin")
env["PATH"] = sycl_bin_path + os.pathsep + env.get("PATH", "")
env_vars["PATH"] = sycl_bin_path + os.pathsep + env.get("PATH", "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be the same change done above, in line 55

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch but this change will be then overwritten by line 66

moreover after this change if something was already in env_vars under PATH or LD_LIBRARY_PATH then it will be lost

maybe:

  • call env.update(env_vars) right after creating env copy
  • do printing somehow as env_str = " ".join(f"{key}={env.get(key)}" for key in env_vars.keys() + "LD_LIBRFARY_PATH" + "PATH")

sycl_lib_path = os.path.join(options.sycl, "lib")
env["LD_LIBRARY_PATH"] = (
env_vars["LD_LIBRARY_PATH"] = (
sycl_lib_path + os.pathsep + env.get("LD_LIBRARY_PATH", "")
)

Expand Down
Loading