Preserve case of username in scopes[1] so getSession caller can obtain it exactly (required when case-sensitive external authorization is being used)
#281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler can obtain it
gjsjohnmurray
added a commit
to gjsjohnmurray/vscode-objectscript
that referenced
this pull request
Jun 26, 2025
|
@gjsjohnmurray Can you fix the whitespace changes before you mark this ready for review? They are making the review difficult. |
gjsjohnmurray
changed the title
session.account.id so getSession caller can obtain itscopes[1] so getSession caller can obtain it exactly (required when case-sensitive external authorization is being used)
|
Commits 5 and 7 together show the only non-whitespace changes. I think the whitespace changes occurred because your previous work in this file resulted in space-indenting, which isn't the convention for this project. |
isc-bsaviano
requested changes
Jun 27, 2025
isc-bsaviano
approved these changes
Jun 27, 2025
|
Should we prepare a release for Monday, or do you want to tackle that bulk account culling issue first? |
|
Let's release on Monday. That enhancement can wait for the next release (or later). |
|
Sounds good, I'll open the PR shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to fixing intersystems-community/vscode-objectscript#1593
Callers of
vscode.authentication.getSessionfor our authprovider should obtain the username by dropping the first /-piece ofsession.account.idin prfeference to usingsession.scopes[1]because the latter has been folder to lowrcase.It replaces #280 and will be used by replacements of intersystems-community/vscode-objectscript#1596 and intersystems/language-server@49e3dc5