fix: remove outdated affiliations link#881
fix: remove outdated affiliations link#881Samk13 wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
* The download link for the affiliations_ror.yaml file has been removed. * see: inveniosoftware/cookiecutter-invenio-rdm#282
| data-file: vocabularies/affiliations_ror.yaml | ||
| ``` | ||
|
|
||
| The `affiliations_ror.yaml` file can be downloaded from [here](https://github.com/inveniosoftware/cookiecutter-invenio-rdm/raw/master/%7B%7Bcookiecutter.project_shortname%7D%7D/app_data/vocabularies/affiliations_ror.yaml). |
There was a problem hiding this comment.
I think we should update it to https://github.com/inveniosoftware/cookiecutter-invenio-rdm/blob/v12.0/%7B%7Bcookiecutter.project_shortname%7D%7D/app_data/vocabularies/affiliations_ror.yaml
There's a bigger question of how to talk about features from old versions.....but using the v12 link is the fastest way to fix this
There was a problem hiding this comment.
The link was valid in v12, but it’s outdated for the current v13 and the upcoming master (v14), as the file is no longer part of the setup, correct?
There was a problem hiding this comment.
One could still use the v12 file in v13 or v14....but it's very out of date and not recommended. Basically everything in the documentation from line 44 onward isn't recommended anymore. But it's possible if some folks want a customized affiliation list they might want to use it. The whole section should probably be re-written with a very small in-line yaml example.
There was a problem hiding this comment.
Maybe let’s get one more opinion on this?
The link’s broken, and that file is no longer in use, so I’m not sure it’s worth keeping this piece of info unless there’s a strong reason to retain the reference.
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
masterbranch.productionbranch following approval or indicate to a maintainer that it should be backported.Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: