Skip to content

fix: remove outdated affiliations link #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Samk13 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove outdated affiliations link #881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/operate/customize/vocabularies/affiliations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ affiliations:
data-file: vocabularies/affiliations_ror.yaml
```

The `affiliations_ror.yaml` file can be downloaded from [here](https://github.com/inveniosoftware/cookiecutter-invenio-rdm/raw/master/%7B%7Bcookiecutter.project_shortname%7D%7D/app_data/vocabularies/affiliations_ror.yaml).
Copy link
Copy Markdown
Contributor

@tmorrell tmorrell Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update it to https://github.com/inveniosoftware/cookiecutter-invenio-rdm/blob/v12.0/%7B%7Bcookiecutter.project_shortname%7D%7D/app_data/vocabularies/affiliations_ror.yaml

There's a bigger question of how to talk about features from old versions.....but using the v12 link is the fastest way to fix this

Copy link
Copy Markdown
Member Author

@Samk13 Samk13 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link was valid in v12, but it’s outdated for the current v13 and the upcoming master (v14), as the file is no longer part of the setup, correct?

Copy link
Copy Markdown
Contributor

@tmorrell tmorrell Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could still use the v12 file in v13 or v14....but it's very out of date and not recommended. Basically everything in the documentation from line 44 onward isn't recommended anymore. But it's possible if some folks want a customized affiliation list they might want to use it. The whole section should probably be re-written with a very small in-line yaml example.

Copy link
Copy Markdown
Member Author

@Samk13 Samk13 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let’s get one more opinion on this?
The link’s broken, and that file is no longer in use, so I’m not sure it’s worth keeping this piece of info unless there’s a strong reason to retain the reference.


Afterwards you will need to import the affiliations. To do so, run the following command
from your instance's folder:

Expand Down