Noref more permissive gnd uri handling

[karkraeg]

❤️ Thank you for your contribution!

Description

This PR aims at simplifying the process of adding a GND ID to a person in the creatibutors modal. Until now users could only paste the actual GND ID, not one of the GND URIs. When researching a GND URI the Website of the german national library looks like this:

So most people will just copy and paste this URI. When then saving or publishing the draft in RDM there will be a "Creators: No valid scheme recognized for identifier." error, which in our opinion is a major inconvenience.

This PR allows for pasting both http://d-nb.info/gnd/<id> and https://d-nb.info/gnd/<id> in addition to GND:<id>, gnd:<id> and <id>. The normalization step is the same as before.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

[tmorrell]

I think gnd_resolver_url is not needed any more.

It's used at the beginning of the validate function, but I don't that's needed after this code change

idutils/idutils/validators.py

Line 238 in 181b3db

def is_gnd(val):

[karkraeg]

its also used at

idutils/idutils/validators.py

Line 240 in 26318e4

if val.startswith(gnd_resolver_url):

but I guess the url does not need to be configurble.

[tmorrell]

I think you can use ? instead of repeating http and https like

idutils/idutils/utils.py

Line 62 in 181b3db

r"(pmid:|https?://pubmed.ncbi.nlm.nih.gov/)?(\d+)/?$", flags=re.I

.

I would also lean toward putting the url in the regex instead of having a variable

[tmorrell]

Could you just use the regex in the normalize function like

idutils/idutils/normalizers.py

Line 73 in 181b3db

def normalize_pmid(val):

[karkraeg]

I updated the regex to match the one from https://www.wikidata.org/wiki/Property:P227 :

[tmorrell]

Looks good, Thanks!

[slint]

minor: is this actually needed now that the regex contains the URL? I feel this if ... clause would only match identifiers without the http(s) protocol in front, i.e. d-nb.info/gnd/12345. Maybe this logic can be captured in the regex?

[tmorrell]

I agree, this can probably be removed.

[karkraeg]

fixed that by chaning the regex accordingly, see https://regex101.com/r/C9VJpH/1