Skip to content

Noref more permissive gnd uri handling #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmorrell merged 9 commits into from
Jan 31, 2025
+4 −12
Merged

Noref more permissive gnd uri handling #114

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cfe0396
accept both `http://d-nb.info/gnd/<id>` and `https://d-nb.info/gnd/<i…
Jan 13, 2025
17d8660
re-use gnd_resolver_url var in regex
Jan 13, 2025
0aad9a4
use the regex in the normalize function
Jan 29, 2025
5e2a5c9
utils: remove var and improve regex
Jan 29, 2025
0e8c06e
validators: dont use var
Jan 29, 2025
6944dab
utils: adapt to correct url match regex
Jan 29, 2025
8901e7c
validators: remove additional check
Jan 31, 2025
e8229a9
utils: improve regex to match for IDs without http prefix in order to…
Jan 31, 2025
2f042b9
validators: adhere to pydocstyle
Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions idutils/normalizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@ def normalize_orcid(val):

def normalize_gnd(val):
"""Normalize a GND identifier."""
if val.startswith(gnd_resolver_url):
val = val[len(gnd_resolver_url) :]
if val.startswith("http://" + gnd_resolver_url):
val = val[len("http://" + gnd_resolver_url) :]
elif val.startswith("https://" + gnd_resolver_url):
val = val[len("https://" + gnd_resolver_url) :]
Copy link
Contributor

@tmorrell tmorrell Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just use the regex in the normalize function like

idutils/idutils/normalizers.py

Line 73 in 181b3db

def normalize_pmid(val):

if val.lower().startswith("gnd:"):
val = val[len("gnd:") :]
return "gnd:{0}".format(val)
Expand Down
5 changes: 3 additions & 2 deletions idutils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,10 @@
https://support.orcid.org/hc/en-us/articles/360006897674-Structure-of-the-ORCID-Identifier
"""

gnd_resolver_url = "d-nb.info/gnd/"
Copy link
Contributor

@tmorrell tmorrell Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think gnd_resolver_url is not needed any more.

It's used at the beginning of the validate function, but I don't that's needed after this code change

idutils/idutils/validators.py

Line 238 in 181b3db

def is_gnd(val):

Copy link
Member Author

@karkraeg karkraeg Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its also used at

idutils/idutils/validators.py

Line 240 in 26318e4

if val.startswith(gnd_resolver_url):
but I guess the url does not need to be configurble.


gnd_regexp = re.compile(
r"(gnd:|GND:)?("
rf"(gnd:|GND:|http://{re.escape(gnd_resolver_url)}|https://{re.escape(gnd_resolver_url)})?("
Copy link
Contributor

@tmorrell tmorrell Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use ? instead of repeating http and https like

idutils/idutils/utils.py

Line 62 in 181b3db

r"(pmid:|https?://pubmed.ncbi.nlm.nih.gov/)?(\d+)/?$", flags=re.I
.

I would also lean toward putting the url in the regex instead of having a variable

r"(1|10)\d{7}[0-9X]|"
r"[47]\d{6}-\d|"
r"[1-9]\d{0,7}-[0-9X]|"
Expand All @@ -91,7 +93,6 @@
)
"""See https://www.wikidata.org/wiki/Property:P227."""

gnd_resolver_url = "http://d-nb.info/gnd/"

urn_resolver_url = "https://nbn-resolving.org/"

Expand Down