compat for new VCS integration#2128
Open
palkerecsenyi wants to merge 11 commits intoinveniosoftware:masterfrom
Open
compat for new VCS integration#2128palkerecsenyi wants to merge 11 commits intoinveniosoftware:masterfrom
palkerecsenyi wants to merge 11 commits intoinveniosoftware:masterfrom
Conversation
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Aug 19, 2025
* We are updating `invenio-github` to be a generic package supporting many VCS providers, not just GitHub. As such, it will be renamed (currently to `invenio-vcs`). * The `RDMGitHubRelease` class has been renamed and restructured, so this must be reflected in `config.py` for continued functionality. No other changes are needed to this repository at the moment. * See inveniosoftware/invenio-rdm-records#2128
16 tasks
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Oct 14, 2025
* We are updating `invenio-github` to be a generic package supporting many VCS providers, not just GitHub. As such, it will be renamed (currently to `invenio-vcs`). * The `RDMGitHubRelease` class has been renamed and restructured, so this must be reflected in `config.py` for continued functionality. No other changes are needed to this repository at the moment. * See inveniosoftware/invenio-rdm-records#2128
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Oct 15, 2025
* We are updating `invenio-github` to be a generic package supporting many VCS providers, not just GitHub. As such, it will be renamed (currently to `invenio-vcs`). * The `RDMGitHubRelease` class has been renamed and restructured, so this must be reflected in `config.py` for continued functionality. No other changes are needed to this repository at the moment. * See inveniosoftware/invenio-rdm-records#2128
palkerecsenyi
commented
Oct 16, 2025
setup.cfg
Outdated
| invenio-drafts-resources>=7.0.0,<8.0.0 | ||
| invenio-records-resources>=8.0.0,<9.0.0 | ||
| invenio-github>=3.0.0,<4.0.0 | ||
| invenio-vcs>=4.0.0,<5.0.0 |
Member
Author
There was a problem hiding this comment.
We still need to make this an optional dependency and ensure we don't crash while importing it if it hasn't been installed.
palkerecsenyi
changed the title
palkerecsenyi
force-pushed
the
vcs
branch
2 times, most recently
from
94c0439 to
27f6742
Compare
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Oct 31, 2025
* We are updating `invenio-github` to be a generic package supporting many VCS providers, not just GitHub. As such, it will be renamed (currently to `invenio-vcs`). * The `RDMGitHubRelease` class has been renamed and restructured, so this must be reflected in `config.py` for continued functionality. No other changes are needed to this repository at the moment. * See inveniosoftware/invenio-rdm-records#2128
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 6, 2025
* We are updating `invenio-github` to be a generic package supporting many VCS providers, not just GitHub. As such, it will be renamed (currently to `invenio-vcs`). * The `RDMGitHubRelease` class has been renamed and restructured, so this must be reflected in `config.py` for continued functionality. No other changes are needed to this repository at the moment. * See inveniosoftware/invenio-rdm-records#2128
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 6, 2025
* We are updating `invenio-github` to be a generic package supporting many VCS providers, not just GitHub. As such, it will be renamed (currently to `invenio-vcs`). * The `RDMGitHubRelease` class has been renamed and restructured, so this must be reflected in `config.py` for continued functionality. No other changes are needed to this repository at the moment. * See inveniosoftware/invenio-rdm-records#2128
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 11, 2025
* We are updating `invenio-github` to be a generic package supporting many VCS providers, not just GitHub. As such, it will be renamed (currently to `invenio-vcs`). * The `RDMGitHubRelease` class has been renamed and restructured, so this must be reflected in `config.py` for continued functionality. No other changes are needed to this repository at the moment. * See inveniosoftware/invenio-rdm-records#2128
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Nov 11, 2025
* We are updating `invenio-github` to be a generic package supporting many VCS providers, not just GitHub. As such, it will be renamed (currently to `invenio-vcs`). * The `RDMGitHubRelease` class has been renamed and restructured, so this must be reflected in `config.py` for continued functionality. No other changes are needed to this repository at the moment. * See inveniosoftware/invenio-rdm-records#2128
palkerecsenyi
added a commit
to palkerecsenyi/invenio-app-rdm
that referenced
this pull request
Jan 8, 2026
* We are updating `invenio-github` to be a generic package supporting many VCS providers, not just GitHub. As such, it will be renamed (currently to `invenio-vcs`). * The `RDMGitHubRelease` class has been renamed and restructured, so this must be reflected in `config.py` for continued functionality. No other changes are needed to this repository at the moment. * See inveniosoftware/invenio-rdm-records#2128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes inveniosoftware/invenio-vcs#2
Description
This PR makes the necessary adaptations for compatibility with the new major version of
invenio-github, now known asinvenio-vcs. This is a working name and is open to discussion: this PR includes the change of name for the module, but it is very easy to update it.invenio-github, we made frequent access to the JSON dicts directly returned from the GitHub API. To allow for genericisation (is that a word?) a new set ofGenericXclasses have been created (GenericRepository,GenericRelease, etc.) containing only a small subset of fields that any VCS service can reasonably be expected to return. The contrib implementations are responsible for the mapping from the API response to the generic class. This way, higher-level operations must rely only on the generic data, so this update is most of what has been changed ininvenio-rdm-records.invenio-rdm-recordswas very specific to GitHub, so this processing has also been moved toinvenio-vcs. It can be implemented for each VCS in accordance with their respective peculiarities.GITHUB_...config variables have been renamed toVCS_...githubtovcs