fix(ionic): use the correct colors in core and playwright #29898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Sep 26, 2024
brandyscarney
approved these changes
Sep 30, 2024
BenOsodrac
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
There are some Sass color mixins that are not being imported correctly. This leads to some components to not have the correct shade or tint.
Playwright was also not importing the correct ionic bundle file, which has caused some snapshots to not be correct. This is apparent when a test uses
setContent. There are several components that are needing their snapshots to be re-generated. In order to not have a PR with an immense amount of snapshots, several PRs will be created to split off the work to make it easier on reviewers.What is the new behavior?
setContentDoes this introduce a breaking change?
Other information
Most of the snapshots were already reviewed and don't need to be reviewed again. Of course, the reviewer is free to look at them. There is a set of snapshots that should be reviewed as those needed to be updated once all the snapshots PRs were merged in. Somehow there were a set that didn't get updated correctly: 0ce9d2c
I recommend filtering out the
.pngduring the initial review to see the code changes.