fix(overlay): prevent detached DOM nodes during React inline overlay dismiss #30344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g setState to stop race conditions
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Currently, the inline overlay component calls setState on dismiss that can cause the component to rerender when it's otherwise trying to be removed from the DOM, preventing elements that should be removed from the DOM from being removed from memory and leading to detached nodes.
What is the new behavior?
We no longer call setState on dismiss. It shouldn't really be necessary anyway, because after dismiss in this case the entire component should be destroyed ultimately. This prevents things that were removed from the DOM from being re-rendered by React and hanging around in memory, preventing detached nodes.
Does this introduce a breaking change?
Other information